Repository navigation
Json and MsgPack decode through a seed, as Packed does - #31
Merged
Merged
Conversation
added 2 commits
October 25, 2026 14:22
Json and MsgPack gain decode_seed, as Packed has, and decode goes through it with PhantomData, so the seeded and derived paths are one. Each spells out its crate's from_slice exactly: serde_json checks the end of input; rmp_serde does not, and trailing bytes stay ignored.
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonandMsgPackgaindecode_seed, with the signaturePacked::decode_seedhas, andWireFormat::decodenow callsself.decode_seed(PhantomData::<T>, bytes), so the seeded and derived paths are the same code.DeserializeSeed, and has to equal decoding into a derived type by construction.Jsonspells outserde_json::from_slice(Deserializer::from_slice, then the seed, thenend()).MsgPackspells outrmp_serde::from_slice(Deserializer::from_read_ref, default config). That function ignores trailing bytes, and this keeps it that way; a doc comment says so.Option, an enum, aVecand a[u8; 4]; both refuse malformed input; a hand-written seed (an integer width chosen at run time) works for each format.