Repository navigation
config: validate_on_decode defaults to collect; off is { off = "reason" } - #116
Merged
Merged
Conversation
This was referenced Nov 3, 2026
Member
Author
|
Conformance golden: the only drift is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounds step 10 (ComlineProject/core#98, ComlineProject/core#197): validators are enforced by default, and turning them off is a give-up that carries its reason.
ValidateOnDecode's default is nowCollect. That covers#[default], the resolver's fallback, and aGenerateRequestbuilt withDefault::default().comline.toml,validate_on_decodeis"collect","first", or{ off = "why" }(newValidateOnDecodeSetting). A bare"off"is refused with the fix ("writevalidate_on_decode = { off = \"why\" }in comline.toml"), and so is an empty reason. There's no deprecation period (early days).--validate-on-decodeandCOMLINE_GENERATE_VALIDATE_ON_DECODEtakecollectorfirst. A reason is written in comline.toml, soofffrom either is refused, naming the flag or variable.ResolvedTarget::validate_on_decode_offholds the reason, for the CLI to show the give-up.GenerateRequest.validate_on_decodeis stilloff/collect/first.schemas/comline-toml.jsonis regenerated (oneOf: a mode, or{ off }with a non-empty reason, defaultcollect), and the schema test covers the new rejects.2d50fbf) and deps: generation with validate_on_decode defaulting to collect comline-typescript#127 (ea9b9e2). The conformance fixtures setvalidate_on_decodeexplicitly, so no golden moves.The generators and the CLI pin
c303722(this PR's first commit). Merge order: this, comline-rust#104, comline-typescript#127, then ComlineProject/cli#130.