Repository navigation
Wire: char and bounds per format, conformance spec 0.3 (core#98) - #144
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 7 of the bounds rollout (ComlineProject/core#98; resume note ComlineProject/core#197), docs part: each format's spec records its
charencoding and its bounds behaviour.reference/wire/packed.md:char: raw UTF-8, 1 to 4 bytes, no prefix.char[max N]/char[N], which always send a byte length, andT[max N].charand bounds" section covers the strict single-charcheck and what decoding refuses: a count above N, a byte length above 4 × N, then the exact character count, and the depth limit.reference/wire/official-encodings.md: a new "charand bounds" section with a table per format (packed@1,msgpack@1,json@1): onechar,T[max N]andchar[max N], plus the depth rule.comline@2shape hash.reference/conformance.md: spec 0.3.char,bounded_string,bounded_array,recursive/self) and the{"char": ...}value.encodecase may carry atype, and anencoderejection must fail to encode.Merge order: after ComlineProject/runtime#78 (the runtime and vectors) and ComlineProject/core#200 (bounds in the shape hash). The link to the runtime README's
#the-spec-version-03anchor resolves once runtime#78 is merged.