Repository navigation
chore: drop dead rmp_serde meta (de)serializer and stale allow(unused) - #85
Merged
Merged
Conversation
added 2 commits
October 12, 2026 02:17
from_schema_meta/to_schema_meta in cas/meta.rs had zero callers anywhere in the codebase - to_schema_meta was never even implemented (todo!()). Same pattern as FrozenUnit::Parameter earlier in this PR: a third, unused serialization path alongside the now-unified CBOR one. Drops the rmp/rmp-serde dependencies entirely.
…terpreter IncrementalInterpreter and its Compile impl are genuinely used now - the allow(unused) attributes predate that and no longer apply (confirmed: removing them produces no dead-code warnings). Also drops a commented-out legacy from_ast/from_sourced_whole block and a stale use import, both already inert.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits that were pushed to
feat/cbor-ir-formatafter #84 was already merged, so they never made it into master - re-opening them against current master.cas/meta.rs'sfrom_schema_meta/to_schema_meta(zero callers anywhere;to_schema_metawas never even implemented, justtodo!()), and drops the now-unusedrmp/rmp-serdedeps. Same pattern as the deadFrozenUnit::Parameterremoved in feat: replace bincode's position-based CAS encoding with name-tagged CBOR #84: a third, unused serialization path alongside the CBOR one.#[allow(unused)]onIncrementalInterpreter/itsCompileimpl - confirmed removing them produces no dead-code warnings, i.e. the type is genuinely used now. Also removes an already-inert commented-out legacy block and a staleuse.No behavior change either way.
Test plan
cargo test: 350 passed, 0 failed (same as feat: replace bincode's position-based CAS encoding with name-tagged CBOR #84's baseline)cargo clippy --all-targets: clean, no new warnings