Repository navigation
deps: changelog entries as highlighted IDL lines in comline doc - #120
Merged
Merged
Conversation
comline-core on core#162's branch (changelog entries carry old/new IDL lines), the generation crates on generation#103's (the renderers show them, plus a theme toggle), and the generators on their matching pin bumps. Generated code is byte-identical.
…on on entries The external-renderer fixture builds the official renderers itself, so it pins the same generation, comline-rust and core revs. The doc test checks the entry's subject and its diff block rather than the old field dump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cli's step of the comline-core cascade for
comline doc's changelog rendering.comline-coreon doc: changelog entries carry their old and new IDL lines core#162's branch: changelog entries carry optionalold/newIDL lines.comline-codegen,comline-doc-html,comline-doc-markdownon doc renderers: changelog entries as highlighted IDL lines, and a theme toggle generation#103's branch: entries render as a severity badge, a linked title and highlighted−/+IDL lines (or a sentence), the changelog heading is just "Changelog", and every HTML page gets a light/dark/auto theme toggle.comline-codegen-rust/-typescripton deps: pin comline-core and generation for changelog IDL lines comline-rust#91 / deps: pin comline-core and generation for changelog IDL lines comline-typescript#110 (pin bumps only).Generated code is byte-identical:
comline generatewith main's binary and this branch's, over the four cli fixtures (simple, chat, validated, conformance_package), Rust and TypeScript,codeandlibmodes: 48 files,diff -rclean.Merge after core#162, generation#103, comline-rust#91 and comline-typescript#110.