Repository navigation
build, diff: report every change kind, config changes and the bump - #115
Merged
Merged
Conversation
Re-pins core to the compatibility rules (core#154) with generation, comline-rust and comline-typescript in step. The renderer prints the new kinds; `diff` runs core's comparison (own schemas, dependencies by reach, config, bump) like `build`; `build` prints config changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cli step of the core#154 cascade (ComlineProject/core#119 step 1: the compatibility rules), with the reporting from #80.
9b8336e(the commit comline-rust#88 and comline-typescript#106 pin); the generators to those PRs.tests/fixtures/generatorsfollows.src/changes.rsrenders the new kinds: added optional field (where the format can't skip it), moved fields / variants / functions (where they travel by position or index), renamed protocol / namespace, same type respelled, a constant only defaults use.comline diffruns core'scas::build::compare, the comparisonbuilduses: the package's own changes, each dependency's within reach (no longer mixed into the package's own), config changes, and the bump.comline buildprints config changes, and a build whose only change is in the config no longer says "no changes".Not here (#80's rest):
--jsonoutput,--deny/versioning.allow.Generated code is byte-identical:
comline generatewith this branch and withmainonsimple_project,chat_projectandvalidated_project, Rustcode, Rustliband TypeScriptcode(24 files),diff -rclean.Local checks:
cargo fmt --check(all three manifests), bothcargo clippyruns,cargo test(121 cli tests).Part of #80.