Repository navigation
v1.27.1: cron time zones — full database, keep the application's one - #190
Merged
Merged
Conversation
- Load the full timezone database (data/latest_all.dart): the default one has no links/aliases (GMT, Europe/Oslo...), rejected as unknown. - A database already loaded by the application is kept; a name not found loads the full database (a superset) and is tried again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 95.53% 95.55% +0.02%
==========================================
Files 73 73
Lines 25174 25179 +5
==========================================
+ Hits 24049 24059 +10
+ Misses 1125 1120 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timezonedatabase (data/latest_all.dart). The default one loaded until now (data/latest.dart) has no links or aliases, so a job withGMT,Europe/OsloorAtlantic/Reykjavikwas rejected as an unknown time zone.Tests
test/bones_api_cron_timezone_db_test.dart(its own isolate, because the database is global): an app-loaded default database is kept; an alias loads the full database; earlier names keep resolving; unknown names still throw; a job withEurope/Osloresolves.dart analyze --fatal-infos: no issues.🤖 Generated with Claude Code