Skip to content

fix: preserve domains in nested route resolution - #690

Open
elpete wants to merge 5 commits into
developmentfrom
fix/module-route-domain-propagation
Open

fix: preserve domains in nested route resolution#690
elpete wants to merge 5 commits into
developmentfrom
fix/module-route-domain-propagation

Conversation

@elpete

@elpete elpete commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • forward the incoming domain while resolving module and namespace route tables
  • preserve the domain during recursive package resolution
  • return an empty nested result instead of treating a module mount point as an executable route
  • correctly recognize normalized explicit /:handler/:action module routes so ColdBox does not append a duplicate convention route
  • add regressions for domain-constrained module routing and convention-route registration

Verification

  • RoutingServiceTest + RouterTest + ModuleSpec: 102 passed on BoxLang 1.16.0+57
  • targeted cfformat check: 4 files passed
  • git diff --check passed
  • CommuniArts integration with cbsecurity-passkeys: supported platform/tenant hosts return 200; an unsupported host returns 404

Note: the repository-wide local format check reports the unchanged system/web/routing/Router.cfc from the base branch; the PR formatting job is green.

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 1241706. ± Comparison against base commit 3088699.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant