fix: support PHP 8.4 property hooks - #62
Open
petrdobr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stub::update()behavior by storing current values per mock.properties.
Root cause
PHPUnit redeclares public hooked properties on the generated mock class so
their hooks can be configured.
Stub::bindParameters()used reflection to write the value to the property ofthe original class. However, reading the property called the getter hook on
the generated mock class, where this value was not available.
The fix detects properties declared directly on the mock, configures their
getter once, and reads the current value from a
WeakMap. SubsequentStub::update()calls replace the stored value without configuring the getteragain.
Properties that are not doubled by PHPUnit continue to use reflection.
The PHP 8.4-only test fixture uses an
.incextension and is loadedconditionally so the test suite remains parseable on PHP 8.1–8.3.
Testing
composer validategit diff --checkFixes #61