fix(common): honor DeepSeek Beijing weekend boundaries - #1096
fix(common): honor DeepSeek Beijing weekend boundaries#1096c8dhjp4tyv-bit wants to merge 3 commits into
Conversation
|
Ran the two functions from this PR, copied verbatim, against our dated vector table for the live DeepSeek schedule. 15 of 15: 12 phase vectors and 3 next-change vectors, including both effective instants and both weekend edges. Over the week beginning Mutation results, since #1090 was about tests staying green:
That second row is the interesting one, and I think this PR gets it right for a reason worth writing down. With the current windows the weekend rule can only change the answer during Exporting One note, not a request: the Vectors are CC0 if they are useful in the suite: https://github.com/xyzs996/deepseek-peak-hours. Thanks for picking this up so quickly. |
43861e6 to
b00d9e9
Compare
Fixes #1090
Summary
Why
The existing weekend tests used instants where UTC and Beijing were already on the same weekend day, so removing the
+8hour conversion left the suite green. The new boundary cases pin Friday 16:00Z and Sunday 16:00Z, where the calendars diverge.Verification
bun test common/src/__tests__/freebuff-peak-hours.test.ts— 26 passedbun run --cwd common typecheck— passedgit diff --check— passedThe full
commontest command cannot pass in this public checkout because several existing tests reference private/web files absent from the mirror; the changed test file passes independently.