HashSet in C#: modernize to .NET 10 and fix test defects - #2107
Closed
vladimir-pecanac-main wants to merge 1 commit into
Closed
HashSet in C#: modernize to .NET 10 and fix test defects#2107vladimir-pecanac-main wants to merge 1 commit into
vladimir-pecanac-main wants to merge 1 commit into
Conversation
- Retarget both projects to net10.0 - Update MSTest to 4.3.3, Microsoft.NET.Test.Sdk to 18.9.0, coverlet.collector to 10.0.1 - Use the HashSet<T>/List<T> Count property instead of the LINQ Count() extension - Correct reversed Assert.AreEqual(expected, actual) argument order - Make RandomInts deterministic by filling the set to the requested size, so the union count assertion no longer flakes on hash collisions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes the HashSetInCSharp sample to .NET 10 and fixes three real test defects: LINQ
Count()where theCountproperty is correct, reversedAssert.AreEqualargument order, and a non-deterministicRandomIntsthat could flake on hash collisions. Package versions bumped to current stable (MSTest 4.3.3, Microsoft.NET.Test.Sdk 18.9.0, coverlet.collector 10.0.1). Build clean, 12/12 tests pass on net10.0.