InitSetters: retarget net10.0, fix swapped Tokyo coordinates - #2106
Closed
vladimir-pecanac-main wants to merge 1 commit into
Closed
InitSetters: retarget net10.0, fix swapped Tokyo coordinates#2106vladimir-pecanac-main wants to merge 1 commit into
vladimir-pecanac-main wants to merge 1 commit into
Conversation
…st packages The City constructor is City(name, latitude, longitude), but Program.cs and CityTests.cs passed 139.839478 as latitude and 35.652832 as longitude - Tokyo's values reversed (139.8 is not a valid latitude). Swap both. Retarget both projects to net10.0 and update the test packages to current versions; keep FluentAssertions on the 6.x line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retarget the InitSetters sample and its test project to net10.0 and bump the test packages to current versions (FluentAssertions kept on the 6.x line). Fix the swapped Tokyo coordinates: the constructor is City(name, latitude, longitude), but both Program.cs and CityTests.cs passed 139.839478 as latitude and 35.652832 as longitude (139.8 is not a valid latitude). Latitude 35.65 / longitude 139.84 are now correct in both places.