fix(reminder): repeat ILS reminder spoken cue every 60s until acknowledged - #144
Merged
Conversation
…edged ReminderViewModel.OnTick played the "Rückmeldung an ILS" spoken cue exactly once per cycle, then stayed silent for as long as the reminder sat unacknowledged. Replace the one-shot _dueAnnounced guard with a _lastAnnouncedAt timestamp so the cue re-announces on a 60s cadence while still due, keeping the reminder insistent instead of easy to miss after the first play. Closes #89 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EgFDVXVsJVKJAw1fxBETFR Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReminderViewModel.OnTicknow re-plays the cue on a 60s cadence while still due, so it stays insistent instead of being said once and forgottenAcknowledge()still resets the cadence so the next cycle announces immediately when it falls dueCloses #89
Test plan
Unacknowledged_reminder_repeats_the_spoken_cue_every_60_seconds— asserts no repeat before 60s, a repeat exactly at 60s, and that acknowledging stops further repeatsBecoming_due_plays_the_spoken_cue_once_per_cycle→Becoming_due_plays_the_spoken_cue_immediately(old assertion — firing twice while due still plays once — was the bug)dotnet test tests/LageBuch.AppLogic.Tests— 286/286 passeddotnet test(full solution) — all projects passed exceptLageBuch.Acceptance.Tests, which fails with a pre-existing xunit v3 process-launch error unrelated to this change (no files in that project touched)No UI changed — view-model-only logic fix, no screenshots needed per AGENTS.md.
🤖 Generated with Claude Code
https://claude.ai/code/session_01EgFDVXVsJVKJAw1fxBETFR