Add auto create prefix - #192
Open
harshil-goel wants to merge 1 commit into
Open
harshil-goel wants to merge 1 commit into
harshil-goel wants to merge 1 commit into
Conversation
serprex
reviewed
Sep 30, 2026
| /// (and the future overlay) retarget namespaces + drop strategy without a | ||
| /// restart. | ||
| /// Prefix derived destination names carry when a namespace sets none | ||
| pub const DEFAULT_AUTO_CREATE_PREFIX: &str = "public_"; |
Member
There was a problem hiding this comment.
this shouldn't be default, table might not even be in public schema
Member
There was a problem hiding this comment.
having something like $schema$_ with $$ to escape $ so people can configure $database$_$schema$_$table$ would be nice, that also supports suffixes with $table$_suffix
serprex
reviewed
Sep 30, 2026
| NamespaceMapping { | ||
| target_database: Some("walshadow_test".into()), | ||
| auto_create: true, | ||
| auto_create_prefix: Some(String::new()), |
Member
There was a problem hiding this comment.
difference between None & Some(String::new())?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.