Repository navigation
Conversation
Latest stable clippy flags needless_borrows_for_generic_args on the three .map_err(&project_state_error) calls. The closure captures nothing and is Copy, so pass it by value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sdairs
force-pushed
the
fix/clippy-needless-borrow-project-state-error
branch
from
October 1, 2026 19:15
f7c2e13 to
1e7384f
Compare
sdairs
added this pull request to stack #1001
October 1, 2026 19:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1041
On the latest stable toolchain, clippy flags
needless_borrows_for_generic_argson the three.map_err(&project_state_error)calls incrates/clickhousectl/src/local/mod.rs. That breaks the "Test clickhousectl" Clippy step on main and on every open PR.project_state_erroris a closure that captures nothing, so it isCopy. This PR passes it by value at each call site.Verification (Rust 1.99.0)
mainwithcargo clippy -p clickhousectl -- -D warningscargo fmt --all: no changescargo clippy -p clickhousectl -- -D warnings: cleancargo clippy -p clickhousectl --all-targets --no-default-features -- -D warnings: cleancargo test -p clickhousectl --bins: 1297 passed. The crate has no lib target, so--libdoesn't apply.🤖 Generated with Claude Code