Skip to content

Fix issue #648 introduced in 0.3.1 - #651

Merged
zhicwu merged 2 commits into
ClickHouse:developfrom
zhicwu:current-database
May 6, 2021
Merged

Fix issue #648 introduced in 0.3.1#651
zhicwu merged 2 commits into
ClickHouse:developfrom
zhicwu:current-database

Conversation

@zhicwu

@zhicwu zhicwu commented May 6, 2021

Copy link
Copy Markdown
Contributor
  • only ignore database parameter when given DDL contains DATABASE keyword
  • change current database of Statement/PreparedStatement as needed
  • add unit test to address regression issue

@zhicwu zhicwu linked an issue May 6, 2021 that may be closed by this pull request
@github-actions

github-actions Bot commented May 6, 2021

Copy link
Copy Markdown
Benchmark                           (client)  (statement)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20   283.777 ±  27.155  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20   293.396 ±  30.924  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  2069.373 ± 255.665  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20  1817.879 ± 301.817  ops/s

@zhicwu
zhicwu merged commit ef925a4 into ClickHouse:develop May 6, 2021
@zhicwu
zhicwu deleted the current-database branch May 6, 2021 02:43
@martenlindblad

Copy link
Copy Markdown

Thanks for fixing this issue. I think this should be a hotfix since it breaks our current setup. We can't use 0.3.1 and it seems like 0.3.2 still is far away from release.

@zhicwu

zhicwu commented Jun 7, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for fixing this issue. I think this should be a hotfix since it breaks our current setup. We can't use 0.3.1 and it seems like 0.3.2 still is far away from release.

Sorry I've been lazy lately :p Just released 0.3.1-patch for this and I'll expedite 0.3.2 release(for real ;).

@zhicwu zhicwu linked an issue Jun 15, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why DDL statements ignore database setting? After update to 0.3.1 datasource ignores database from url

2 participants