Skip to content

Fix error when use_new_parser is set to false - #618

Merged
zhicwu merged 2 commits into
ClickHouse:developfrom
zhicwu:disable-new-parser
Apr 10, 2021
Merged

Fix error when use_new_parser is set to false#618
zhicwu merged 2 commits into
ClickHouse:developfrom
zhicwu:disable-new-parser

Conversation

@zhicwu

@zhicwu zhicwu commented Apr 10, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@zhicwu zhicwu linked an issue Apr 10, 2021 that may be closed by this pull request
javacc parser is very slow to parse sql #615
Closed
@zhicwu

zhicwu commented Apr 10, 2021

Copy link
Copy Markdown
Contributor Author

When use_new_parser is set to false, the driver should append FORMAT TabSeparatedWithNamesAndTypes to the given query before passing the query to Clickhouse.

@github-actions

github-actions Bot commented Apr 10, 2021

Copy link
Copy Markdown 
Benchmark                           (client)  (statement)   Mode  Cnt       Score       Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  646215.865 ± 46746.104  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20     276.095 ±    30.010  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20    1712.657 ±   206.088  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20    1761.727 ±   173.615  ops/s

@github-actions

github-actions Bot commented Apr 10, 2021

Copy link
Copy Markdown 
Benchmark                           (client)  (statement)   Mode  Cnt       Score       Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  558959.864 ± 19928.789  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20     274.867 ±    27.013  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20    1345.923 ±   211.813  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20    1354.657 ±   193.988  ops/s

@zhicwu
zhicwu merged commit d508f0a into ClickHouse:develop Apr 10, 2021
@zhicwu
zhicwu deleted the disable-new-parser branch April 10, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

javacc parser is very slow to parse sql

1 participant

@zhicwu