Integration Spec - #2914
Conversation
|
Repository collaborators can run the JMH benchmark suite against this PR by commenting: Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%): Only one benchmark run per PR is active at a time — issuing a new |
mshustov
left a comment
There was a problem hiding this comment.
for partners, I'd consider adding recommended "acceptance criteria" as a separate document (can be done in a follow-up)
my braindump:
- validate functional correctness: number of rows = intended, data type conversion in a roundtrip, handles schema behaviour gracefully (type mismatch, missing column, extra column, etc)
- failure path: idempotent insert, handles retryable (network) and non-retryable errors, handles failures for long operations (1h+)
- no memory leaks under "long process" or bursty workload
- test against their own latency vs thoroughput vs parts count criteria
- operational readiness: configures client_name, can enable logging
- cloud readiness: handles idle instances, long query (1h+) failures, etc
- has auto tests against supported CH versions
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d7eab37. Configure here.

Summary
Checklist
Delete items not relevant to your PR: