Skip to content

Add to aws S3Client constructor with custom AwsAuthSigner. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexey-milovidov merged 1 commit into from
May 21, 2020
Merged

Add to aws S3Client constructor with custom AwsAuthSigner. #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions aws-cpp-sdk-s3/include/aws/s3/S3Client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,14 @@ namespace Aws
S3Client(const std::shared_ptr<Aws::Auth::AWSCredentialsProvider>& credentialsProvider,
const Aws::Client::ClientConfiguration& clientConfiguration = Aws::Client::ClientConfiguration(), Aws::Client::AWSAuthV4Signer::PayloadSigningPolicy signPayloads = Aws::Client::AWSAuthV4Signer::PayloadSigningPolicy::Never, bool useVirtualAddressing = true, Aws::S3::US_EAST_1_REGIONAL_ENDPOINT_OPTION USEast1RegionalEndPointOption = Aws::S3::US_EAST_1_REGIONAL_ENDPOINT_OPTION::NOT_SET);

/**
* Initializes client to use specified auth signer with specified client config. If http client factory is not supplied,
* the default http client factory will be used
*/
S3Client(const std::shared_ptr<Aws::Client::AWSAuthSigner>& signer,
const Aws::Client::ClientConfiguration& clientConfiguration = Aws::Client::ClientConfiguration(), bool useVirtualAddressing = true, Aws::S3::US_EAST_1_REGIONAL_ENDPOINT_OPTION USEast1RegionalEndPointOption = Aws::S3::US_EAST_1_REGIONAL_ENDPOINT_OPTION::NOT_SET);


virtual ~S3Client();

inline virtual const char* GetServiceClientName() const override { return "S3"; }
Expand Down
9 changes: 9 additions & 0 deletions aws-cpp-sdk-s3/source/S3Client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,15 @@ S3Client::S3Client(const std::shared_ptr<AWSCredentialsProvider>& credentialsPro
init(clientConfiguration);
}

S3Client::S3Client(const std::shared_ptr<AWSAuthSigner>& signer,
const Client::ClientConfiguration& clientConfiguration, bool useVirtualAddressing, Aws::S3::US_EAST_1_REGIONAL_ENDPOINT_OPTION USEast1RegionalEndPointOption) :
BASECLASS(clientConfiguration, signer, Aws::MakeShared<S3ErrorMarshaller>(ALLOCATION_TAG)),
m_executor(clientConfiguration.executor), m_useVirtualAddressing(useVirtualAddressing), m_USEast1RegionalEndpointOption(USEast1RegionalEndPointOption)
{
init(clientConfiguration);
}


S3Client::~S3Client()
{
}
Expand Down