Repository navigation
Docs: sync upstream clickhouse-operator docs updates - #123072
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
Workflow [PR], commit [83bf8ef] Summary: ✅ AI ReviewSummaryThis PR syncs the upstream Keeper leadership-handover docs into the operator guide and adds Findings
Final Verdict
|
| waiting is what keeps the leaderless window bounded. | ||
|
|
||
| The hook needs no configuration and degrades gracefully: on Keeper versions older than | ||
| 26.3, which don't yet serve the leadership commands used here, the request is a no-op and |
There was a problem hiding this comment.
This compatibility floor looks wrong. ydld itself was added in 361472b29e06 (2023-11-06), and the Keeper http_control commands endpoint landed in bc50b68f0558 (2024-05-13), so versions well before 26.3 already expose the command path this hook uses. As written, the guide tells users on earlier releases to expect a no-op when the handover hook should already work. Please either document the real minimum version/capability boundary here or drop the 26.3 claim.
Summary
Sync Keeper leadership handover docs from ClickHouse/clickhouse-operator#351.
Changes
products/kubernetes-operator/guides/configuration.mdx: add "Leadership handover on termination" section (defaultpreStophook usingydld).products/kubernetes-operator/reference/api-reference.mdx: addlifecyclefield toContainerTemplateSpec.Context
Copied verbatim from upstream commit
09774ab. Review requested from the upstream author, Muhammad Soliman (commit email devadel@gmail.com). I couldn't find their GitHub handle, so please add them as a reviewer by hand.Notes / issues (fix upstream first)
containerTemplate.lifecycle— see"). This goes against the style guide.yldl, but the docs and PR description sayydld. Please confirm the correct command name.#containertemplatespecanchor is present. The full broken-links check timed out, so link checking was not completed.Changelog category (leave one):
Workflow [PR]
Sync PR [sync-upstream/pr/123072]
Version info
26.10.1.1097-master(included in26.10and later)