Repository navigation
Fix empty bubbles - #34
Merged
Merged
Conversation
rdehuyss
approved these changes
Mar 26, 2026
Collaborator
|
P.s. there is a branch that saves tool calls but it negatively impacts token usage in the long run |
a-simeshin
added a commit
to a-simeshin/JavaClaw
that referenced
this pull request
Apr 10, 2026
…s с 11 Playwright E2E тестами покрывающими E4 (SSE push → success/error/approval toasts), E5 (error card rendering), E9 (approval respond API + pending approvals + text reply), E10 (expired approval timeout + 404 on respond), E19 (SSE endpoint conversation-routing) — TypeScript/Vite build чистые, все 105 frontend и 537 backend тестов зелёные
a-simeshin
added a commit
to a-simeshin/JavaClaw
that referenced
this pull request
Apr 11, 2026
…st per role — V33 миграция, SkillRoleAllowlist entity/repository, SkillVisibilityService, REST API endpoints для visibility и allowlist, 17 новых тестов, все 1046 тестов зелёные
arefbehboudi
pushed a commit
to arefbehboudi/JavaClaw
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply filters out empty string from agent response. Empty string is returned by Spring AI when the agent is making a tool call.
See #23 for discussion around showing the actually tool calls in the web chat