Wallet Connect QR code error fix - #711
Merged
Merged
Conversation
This reverts commit a555894.
+ dlls ignored again in .gitignore for packages since we now use CI to generate them + Delete WC storage file if session isn't being restored + Save files closer to project when Application.isEditor for convenience
auto-assign
Bot
requested review from
RyRy79261,
juans-chainsafe,
kalambet,
kantagara,
oleksandrchainsafe and
sneakzttv
November 7, 2023 07:15
robGG1997
added
the
ready-to-merge
sneakzttv
approved these changes
Nov 7, 2023
RyRy79261
approved these changes
Nov 7, 2023
juans-chainsafe
approved these changes
Nov 7, 2023
juans-chainsafe
left a comment
juans-chainsafe
left a comment
Contributor
There was a problem hiding this comment.
Wallect connect QR looks good!
kantagara
approved these changes
Nov 7, 2023
robGG1997
added
ready-to-merge
robGG1997
force-pushed
the
rob/wc-qr-error-fix-697
branch
from
November 8, 2023 06:13
6a985f8 to
0c5ff79
Compare
robGG1997
added
ready-to-merge
robGG1997
requested review from
RyRy79261,
juans-chainsafe,
kantagara and
sneakzttv
November 8, 2023 06:38
sneakzttv
approved these changes
Nov 8, 2023
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * Changes made + dlls ignored again in .gitignore for packages since we now use CI to generate them + Delete WC storage file if session isn't being restored + Save files closer to project when Application.isEditor for convenience * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * reverted unwanted changes back to main * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * Changes made + dlls ignored again in .gitignore for packages since we now use CI to generate them + Delete WC storage file if session isn't being restored + Save files closer to project when Application.isEditor for convenience * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * reverted unwanted changes back to main * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #697