-
Notifications
You must be signed in to change notification settings - Fork 245
Login.cs Refactor #641
Copy link
Copy link
Closed
Labels
Type: EnhancementAdded to issues and PRs when a change includes improvements or optimizations.Added to issues and PRs when a change includes improvements or optimizations.Type: MaintenanceAdded to issues and PRs when a change is for repository maintenance , such as CI or linter changes.Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.Version: 2.5All the issues related to 2.5All the issues related to 2.5
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
Type: EnhancementAdded to issues and PRs when a change includes improvements or optimizations.Added to issues and PRs when a change includes improvements or optimizations.Type: MaintenanceAdded to issues and PRs when a change is for repository maintenance , such as CI or linter changes.Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.Version: 2.5All the issues related to 2.5All the issues related to 2.5
Type
Fields
Priority
None yet
Summary
Login script in samples is outdated and needs to be refactored based on current implementation. Proper Wallet Linking DevEx and UX for different platforms using Wallet Connect - Currently Wallet Linking DevEx and UX are not entirely accurate for all platforms and must follow specific steps for connecting/login
Suggested features or ways to address the summary
Auto Login and Login with existing wallet needs to be refactored, For Mobile follow https://docs.walletconnect.com/web3wallet/mobileLinking and Duplicate IOS steps for Desktop and Editor. When listing supported wallets for IOS/Desktop/Editor make sure to check if Wallets are supported on current platform.
Motivation
Results in a cleaner, modular and readable solution