Skip to content

fix: use smaller skip length for tipset_by_height cache #6880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanabi1224 merged 3 commits into from
Apr 9, 2026
Merged

fix: use smaller skip length for tipset_by_height cache #6880

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adfa0a5
fix: use smaller skip length for `tipset_by_height` cache
hanabi1224 Apr 9, 2026
349e23b
Merge remote-tracking branch 'origin/main' into hm/use-small-skip-length
hanabi1224 Apr 9, 2026
74bbc5c
resolve comments
hanabi1224 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/chain/store/index.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ impl<DB: Blockstore> ChainIndex<DB> {
let ts_height_cache: SizeTrackingLruCache<ChainEpoch, TipsetKey> =
SizeTrackingLruCache::new_with_metrics(
"tipset_by_height".into(),
// 20480 * 900 = 18432000 which is sufficient for mainnet
nonzero!(20480_usize),
// 1048576 * 20 = 20971520 which is sufficient for mainnet
Comment thread
hanabi1224 marked this conversation as resolved.
// Maximum ~32MiB RAM usage
nonzero!(1048576_usize),
Comment thread
hanabi1224 marked this conversation as resolved.
);
Self {
ts_cache,
Expand Down Expand Up @@ -152,8 +153,9 @@ impl<DB: Blockstore> ChainIndex<DB> {
) -> Result<Tipset, Error> {
use crate::shim::policy::policy_constants::CHAIN_FINALITY;

// use `CHAIN_FINALITY` as checkpoint interval
const CHECKPOINT_INTERVAL: ChainEpoch = CHAIN_FINALITY;
// use `20` as checkpoint interval to match Lotus:
// <https://github.com/filecoin-project/lotus/blob/v1.35.1/chain/store/index.go#L52>
const CHECKPOINT_INTERVAL: ChainEpoch = 20;
fn next_checkpoint(epoch: ChainEpoch) -> ChainEpoch {
epoch - epoch.mod_floor(&CHECKPOINT_INTERVAL) + CHECKPOINT_INTERVAL
}
Expand Down
Loading