eth_getBlockByHash: performance issue

[AlexeyKrasnoperov]

Describe the bug

I request the eth_getBlockByHash method.
Forest responds in 57 ms, while Lotus returns the same response in 5 ms.

To reproduce

Curl request:

curl -X POST -w '\nTotal: %{time_total}s\n' http://localhost:2345/rpc/v1 \
-H 'Content-Type: application/json' \
-d '{
  "jsonrpc": "2.0",
  "method": "eth_getBlockByHash",
  "params": [
    "0xa97188340005fc4e5f5f2740956ca2d0e07661db8ab4bc79e38a3cc26689612a", false
  ],
  "id": 1
}'

Response

{"id":1,"jsonrpc":"2.0","result":{"hash":"0xa97188340005fc4e5f5f2740956ca2d0e07661db8ab4bc79e38a3cc26689612a","parentHash":"0x9b414db455462705c862eadf5ef5b3172aa8c1b1d6b936d32f3a4b337d29e048","sha3Uncles":"0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347","miner":"0x0000000000000000000000000000000000000000","stateRoot":"0x0000000000000000000000000000000000000000000000000000000000000000","transactionsRoot":"0x0000000000000000000000000000000000000000000000000000000000000000","receiptsRoot":"0x0000000000000000000000000000000000000000000000000000000000000000","logsBloom":"0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","difficulty":"0x0","totalDifficulty":"0x0","number":"0x524ac7","gasLimit":"0xba43b7400","gasUsed":"0x4ae33fd1f","timestamp":"0x68e8fbb2","extraData":"0x","mixHash":"0x0000000000000000000000000000000000000000000000000000000000000000","nonce":"0x0000000000000000","baseFeePerGas":"0x3b28","size":"0x0","transactions":["0x1a9ba28c2c862127a4d302c2d987cd1229094a1e09f2ddd5d136e2239c259fc7","0xb21a8fa8f138fc388ed9190b99d8140bed878d698baf3fe9f8ec7cfce40cf1c1","0x97c92aa9761714ee9628da87819cc320359c919d66f7c64c3ad941f12c144b8e","0x169eb5f1589c31646f1bb4886bdcc8a779930b159bfc9eef845813e28df942b5","0x60abbf552b7cfc1733d43905dace8771da6683acec7a1852c157189cdbc51e94","0xc7f8354b4fc0400cbfd1d2f307018e36fe201b1d2ef9c62c9719df0a041323e2","0x41462def50e9647dc31c7d943b37997c729e847f3ca919fc7557a33945ce5df1","0x29ab553ac069e7790d307e0dee5325d59ace290f1b87db22b53ba7c75cc2fdc7","0x6ab2e6d8d3dabf81b9501ecf5d90b9bab3c980305380fa9601cc4ea8c7a3a599","0xd414bc0094a70040b05558c93815ca7ea38a4d41a11fe0e8dba28a565d4c316d","0xc2ed95704eb8a6cf7ff8d028a92bfc8649baeb0fa7234c22e4e567ec7bc8cde5","0x1a233b15f1f036abbc701178492433326416e6d0bcaff53862b4c130010eb200","0xccdfabc40a4d34411a0a494b21104d2f1b99330367dfce49d67f31dbf3c5b2e5","0xf7239f7090ee1a9f51d21ccfd38b5e124ef0453a63d996fa52bdfc5c87ccc8a4","0x42e190424072e424f87652e6ad74fc5a9681dc12ea639c9807ef2c6efbff9bd6","0x6f8dedbf40bfc5f3e5306b9eba4783b8f821cb276790734da9867f9d3255fbf8","0x3f4647bd3cfcd7af8c4c31609dacc599133fe7f6be58d676837c13ff895114c3","0x760e88c5b687aa08cc971a576e6896f5d7db29fec8e90d940a9db4ce27733963","0xe7bc920d1a239d516322044ce746e82c11a8c42df9db7a7798b978dd1137d79e","0xe301a19279261482af8d9bab2def67ac554c7e3d7d90b2384366e4aea5cce5e1","0xbb9e2ace6a48c0d1683e7f079cdb9da33c50e9a1479af7597d165437b15e58f6","0x71d5839ad53232be24ebe6879c9530337486e0a1fa40a61257316804196f683f","0xddb251995b337f3d48506c9e5df773afd835858065ce8f578fda3a38dfe39913","0x748e07cbff33667eb2a82708ac75f24255169f5af82d29ad0a7a156fb96f2222","0xaf40d8ded559968aebb90c3d81a07d3a33980077aacc855a1b8827544bb7fd4c","0xcb9bdc2e45f15a8528e3578e83e1b1737e9708e7573a44ee5c25e81b58325014","0x5748d609ab00522aa3c96a52bb0ccac0636b013bae7f30c383e9825e9439b7af","0xdbe0b49badb38fcb17382c14c5542b159b303e542a306742a6740702fe46891f","0x49f16dccccd44a3bebfcbabb0392c466acde83ecaaff6c8baf1c83241581f3d2","0xf0097e687879fb322dd8ce8612e724018a6cfe02a91cf41aa7ab61ddeae0791c","0xbb3fa02b9d24c8987026de8234aee0c84ac76777c0a6dbbf6af747a6caacc5b4","0x4ffc66e2a19f3c9e5a4e94669c8a2c0ab385963d091c91f44c577526910c46a0","0xb2ccab765dd21dc909ddda3bfc18ab3c7dc843394d2f487234e56bae7ba8d37d","0x7dc2260b7823e200f63818f49923137df9332a0fb9367d8e078751d1bd0912d5","0xff154a9e43a0c8a79091ec48921ff5ceb49cbf9c885676009cc8e3bd23a467da","0xf21c803b557dc21e7cd5d5de853e34b57864c5a75bd3569411ecb0eb828edee2","0xc01b03660986a985478f17b37a71862a818b1e3205a77a4d3bfa14d0dd5223d7","0xfe3557621a6092f6bc7ec0cb92f0b81bb36224c729644394342ab21f114017df","0xfe2e1679ed741e4822ffb66e8d52c1b7d2f234eab7e132f0bf12658a452f0891","0xecd98e5381bcf37b699d4d93ba370b5f2d4b2253be50f7fa70e924bdb8764802","0x550a6f26bac5d27bba70897bf8219e7cac7728dbe4b03ccbdf3d621d7ea0ef0c","0xd3ff70bdcb0518d3cf7b012dc1a1ffc4836b169b56617af5e297f4bd5c8697d2","0x536066ef999f9fc46f1078ed631f07d10b3f6f5cf1b3a2d577a3006c3a94cbda","0x806561045ae9a27e05b80e19496f43a76f71d2c096770530ab5288ced72e62b1","0xa460efc3715c19fc58a5d4f7bdd90ae08ea1feddeddc56c1b9b924dd05e7bab7","0x91e52f72956645aa5b474e6e81f04f5c9032ae9e8e601d866e39f1ba82ad06fb","0xf2cea54bf222a3af83ed664b4c2abebafa785f91fb4f803d800447856fdb9979","0xb88d223329fa3987ee567dcec91b2b68b2332181085a8cc904ec2826d3dc7c9a","0x5093628bdb6b0e39d0b6c3a4b8a0913d9f525639b64295660d1203d49b71e860","0xf8c5e904aa9a286b97fda62c94f2ded972927f17f1fda1f79975d6f315fce400","0x54570acaccfb3e7e8e7aecbe24b4f92398434676b8730ac9c8a2f7a89064cc1f","0x1b1adc60381a89f12d041aca918a97acc50be4b35f473725c41ba4cef35bb71f","0x78cefd009df7c0644e1de621361e653c961769f443285085b71113e1fe240885"],"uncles":[]}}

Measure performance

Download and setup the filecoin-benchmark-suite.

git clone https://github.com/ChainSafe/filecoin-benchmark-suite.git
cd filecoin-benchmark-suite
npm install

Generate fresh methods request definitions.

npm run build-requests

Benchmark the method.

k6 run -e K6_RPC_URL=http://localhost:2345/rpc/v1 -e K6_METHOD=eth_getBlockByHash tests/single_method.js --duration 30s --vus 20

Expected behaviour

Forest responds in <= 5 ms.

Environment (please complete the following information):

• Hardware
  • 4-core CPU, 32Gb RAM

[AlexeyKrasnoperov]

The performance didn't improve, ~55ms.