Skip to content

fix(fee-compare): total position value + inline vault fee explanation #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 2 commits into from
Aug 29, 2026
Merged

fix(fee-compare): total position value + inline vault fee explanation #2208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9665f39
fix(fee-compare): rename Volume→Position size + clearer vault fee label
Flotapponnier Aug 29, 2026
e089b59
fix(fee-compare): show total position value + inline vault fee explan…
Flotapponnier Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/components/fee-compare-client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,24 +741,29 @@ function WalletSide({
return (
<div className="bg-ink/4 rounded-xl p-3 space-y-2">
<div className="flex items-center justify-between">
<p className="text-[10px] uppercase tracking-[0.14em] text-ink-faint">Volume</p>
<p className="text-[10px] uppercase tracking-[0.14em] text-ink-faint">Total position value</p>
<p className="font-mono text-xs font-semibold text-ink">{fmtUsd(volume)}</p>
</div>
<p className="text-[10px] text-ink-faint/60 leading-snug">
Sum of (collateral × leverage) across all trades in the period.
</p>
<div className="border-t border-ink/8 pt-2 space-y-1.5">
<div className="flex items-center justify-between">
<p className="text-[11px] text-ink-faint">Taker fees</p>
<p className="font-mono text-xs font-semibold text-ink">{fmtUsd(gW.feesUsdc)}</p>
</div>
{hasVault && (
<div className="flex items-center justify-between">
<p className="text-[11px] text-ink-faint">
OI vault fee{" "}
<span className="text-[9px] text-ink-faint/50 italic">OI imbalance surcharge</span>
</p>
<p className="font-mono text-xs font-semibold text-amber-500">
+{fmtUsd(gW.vaultFeesUsdc)}
<>
<div className="flex items-center justify-between">
<p className="text-[11px] text-ink-faint">Vault fee</p>
<p className="font-mono text-xs font-semibold text-amber-500">
+{fmtUsd(gW.vaultFeesUsdc)}
</p>
</div>
<p className="text-[10px] text-ink-faint/60 leading-snug">
Gains charges an extra fee to LPs when your trade increases the long/short imbalance. Hyperliquid does not have this — it uses funding rates instead.
</p>
</div>
</>
)}
{hasFunding && (
<div className="flex items-center justify-between">
Expand Down Expand Up @@ -1220,7 +1225,7 @@ function GainsTradeTable({
<p className="font-mono text-xs font-bold text-ink">{fmtUsd(netCost)}</p>
<p className="text-[10px] text-ink-faint/70 mt-0.5 whitespace-nowrap">
{fmtUsd(t.tradingFee)} taker
{hasVault ? ` +${fmtUsd(t.vaultFee)} vault` : ""}
{hasVault ? ` +${fmtUsd(t.vaultFee)} vault LP` : ""}
{t.borrowingFee > 0.001 ? ` +${fmtUsd(t.borrowingFee)} borrow` : ""}
{Math.abs(t.fundingFee) > 0.001
? ` ${t.fundingFee > 0 ? "+" : "−"}${fmtUsd(Math.abs(t.fundingFee))} fund`
Expand Down
Loading