Skip to content

fix: split Gains taker vs vault fee, add per-trade equiv fee column - #2178

Merged
Flotapponnier merged 1 commit into
devfrom
feat/gains-vault-fee-split
Aug 28, 2026
Merged

fix: split Gains taker vs vault fee, add per-trade equiv fee column#2178
Flotapponnier merged 1 commit into
devfrom
feat/gains-vault-fee-split

Conversation

@Flotapponnier

@Flotapponnier Flotapponnier commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Separates Gains feesUsdc into pure taker fee (from uiRealizedPnlData) and OI vault surcharge (from tradeFeesData - uiRealizedPnlData), fixing inflated bps reporting
  • Shows vault fee separately in the wallet breakdown with amber color and label "OI imbalance surcharge"
  • Adds per-trade HL equivalent fee column to the Gains trade table (like the HL table already has), with diff highlighted green/red
  • avgFeeRateBps now uses taker fee only for an apples-to-apples comparison

Test plan

  • Compare HL vs Gains with a Gains wallet — breakdown should show "Taker fees" + "OI vault fee" separately
  • Gains trade table should show "{venueName} fee" and "{otherVenueName} fee" columns side by side
  • Net cost total should be unchanged (taker + vault + funding + borrowing)

@Flotapponnier
Flotapponnier merged commit d92ebcc into dev Aug 28, 2026
1 check failed
@Flotapponnier Flotapponnier mentioned this pull request Aug 28, 2026
Merged
Flotapponnier added a commit that referenced this pull request Aug 28, 2026
@Flotapponnier
merge: dev → main (fee-compare improvements) (#2179)
0bb493f 
* fix: restore chainstack findings, new key live on both regions

* fix: us-east only bench, drop us-west dimension and service

* feat: add eu-west + sgp regions, chainstack wins all 3

* feat: GMX v2 funding rates via DataStore OI imbalance (#2153)

* feat: bench #243 keyed-rpc-robinhood — 3-region live data (#2154)

* remove non-functional eu/sgp Railway scrape targets from Railway Prom (VPS harnesses take over)

* bump cache keys v62/v29 for eu-west+sgp VPS harness data

* fix(keyed-rpc-robinhood): Alchemy leads global avg + eu-west/sgp, Chainstack wins us-east

* revert: us-east only, no dimensions, Chainstack leads

* fix: pin robinhood bench queries to region=us-east

* remove non-functional eu/sgp Railway scrape targets from Railway Prom (VPS harnesses take over)

* bump cache keys v62/v29 for eu-west+sgp VPS harness data

* fix(keyed-rpc-robinhood): Alchemy leads global avg + eu-west/sgp, Chainstack wins us-east

* revert: us-east only, no dimensions, Chainstack leads

* fix: pin queries to region=us-east to ignore stale eu/sgp prom data

* fix: augment HL position reconstruction with clearinghouseState to bypass 2000-fill cap (#2159)

* feat(rpc): add Litecoin, Babylon, Acala, Interlay benches (#246-249) (#2166)

* fix(rpc): remove em dashes from acala/babylon/interlay bench YAMLs (#2168)

* feat(rpc): add Litecoin, Babylon, Acala, Interlay benches (#246-249)

* fix(rpc): remove em dashes from seo_intro in acala/babylon/interlay YAMLs

* fix: direction-aware funding projection for all venues (#2163)

* fix(ci): smoke against deploy URL, not CDN-cached openchainbench.com

* fix: augment HL position reconstruction with clearinghouseState to bypass 2000-fill cap

* fix(ci): add checkHost arg to smoke — sitemap from deploy URL, pages on prod

* fix: direction-aware funding projection for all venues

* fix(rpc): replace dead Acala/Interlay providers with live endpoints

* fix: correct Robinhood Chain launch date and remove unverified provider claim (#2174)

* feat: pre-fill wallet from URL params on fee-compare (#2176)

* fix(rpc): replace dead Acala/Interlay providers with live endpoints

* feat: pre-fill wallet/venues from URL search params on fee-compare page

* fix: shareable URL uses query params not broken path format (#2177)

* fix(ci): smoke against deploy URL, not CDN-cached openchainbench.com

* fix: augment HL position reconstruction with clearinghouseState to bypass 2000-fill cap

* fix: restore chainstack findings, new key live on both regions

* fix: us-east only bench, drop us-west dimension and service

* feat: add eu-west + sgp regions, chainstack wins all 3

* feat: GMX v2 funding rates via DataStore OI imbalance (#2153)

* feat: bench #243 keyed-rpc-robinhood — 3-region live data (#2154)

* remove non-functional eu/sgp Railway scrape targets from Railway Prom (VPS harnesses take over)

* bump cache keys v62/v29 for eu-west+sgp VPS harness data

* fix(keyed-rpc-robinhood): Alchemy leads global avg + eu-west/sgp, Chainstack wins us-east

* revert: us-east only, no dimensions, Chainstack leads

* fix: pin robinhood bench queries to region=us-east

* remove non-functional eu/sgp Railway scrape targets from Railway Prom (VPS harnesses take over)

* bump cache keys v62/v29 for eu-west+sgp VPS harness data

* fix(keyed-rpc-robinhood): Alchemy leads global avg + eu-west/sgp, Chainstack wins us-east

* revert: us-east only, no dimensions, Chainstack leads

* fix: pin queries to region=us-east to ignore stale eu/sgp prom data

* fix(ci): add checkHost arg to smoke — sitemap from deploy URL, pages on prod

* fix(sitemap): filter removed benches, HL spec slugs, add zerion/routescan to removed products

* fix(sitemap): isHlBuilderSlug filter + exclude REMOVED_BENCH_SLUGS from categories

* sync: merge dev into main (benches 246-249 + recent fixes) (#2167)

* fix: restore chainstack findings, new key live on both regions

* fix: us-east only bench, drop us-west dimension and service

* feat: add eu-west + sgp regions, chainstack wins all 3

* feat: GMX v2 funding rates via DataStore OI imbalance (#2153)

* feat: bench #243 keyed-rpc-robinhood — 3-region live data (#2154)

* remove non-functional eu/sgp Railway scrape targets from Railway Prom (VPS harnesses take over)

* bump cache keys v62/v29 for eu-west+sgp VPS harness data

* fix(keyed-rpc-robinhood): Alchemy leads global avg + eu-west/sgp, Chainstack wins us-east

* revert: us-east only, no dimensions, Chainstack leads

* fix: pin robinhood bench queries to region=us-east

* remove non-functional eu/sgp Railway scrape targets from Railway Prom (VPS harnesses take over)

* bump cache keys v62/v29 for eu-west+sgp VPS harness data

* fix(keyed-rpc-robinhood): Alchemy leads global avg + eu-west/sgp, Chainstack wins us-east

* revert: us-east only, no dimensions, Chainstack leads

* fix: pin queries to region=us-east to ignore stale eu/sgp prom data

* fix: augment HL position reconstruction with clearinghouseState to bypass 2000-fill cap (#2159)

* feat(rpc): add Litecoin, Babylon, Acala, Interlay benches (#246-249) (#2166)

* fix(rpc): remove em dashes from acala/babylon/interlay seo_intro (#2170)

* fix(rpc): replace dead Acala/Interlay providers with live endpoints

* fix(rpc): remove em dashes from acala/babylon/interlay seo_intro

* fix(rpc): replace dead Acala/Interlay providers with live endpoints

* fix: use query params for shareable URL instead of broken path format

* fix: split Gains taker vs vault fee, add per-trade equiv fee column (#2178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Flotapponnier