Repository navigation
Show a spinner while Step 4 calculates statistics - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking Calculate statistics now shows an animated spinner immediately, with messages for reading the histogram table, calculating group statistics and drawing the distributions. The button says Calculating… and is disabled until the work finishes. Previously, Step 4 gave no feedback during calculation and announced completion before plotting finished.
The button is restored on success or failure. Read errors keep their existing message; unexpected calculation or plotting errors show an error card and record a traceback in Technical details. Repeated requests while busy are ignored.
Decisions
Reuse the existing notebook spinner and button styling. Document the interaction in the user guide and plan.
Notes for review
Tests
ruff check .,ruff format --check .andgit diff --checkpass.