Repository navigation
Keep an unreadable experiment_design.csv untouched in step 1 - #61
Merged
Merged
Conversation
When step 1 could not read a saved experiment_design.csv (for example a confirmed_on that a spreadsheet program rewrote as 26/10/2026, refused since #59), it fell back to the default design and wrote it at once, before any answer, so the confirmed answers in the file were lost. Owner decision of 31 October 2026 (plan §12 question 42): the file is left unchanged and refused. Step 1 shows the refusal in a red box, naming the line and column, starts the questions unanswered and writes nothing until the user corrects the file and confirms the labels again, or answers a question, which replaces the file. Step 3 still runs only once every group is confirmed. The command line already refused such a file without writing it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WX6rdMV1r5jUPUR94kxV5a
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the note on #59: when step 1 could not read a saved
experiment_design.csv,_open_designfell back to the default design and called_save_designat once. The user's confirmed answers were overwritten before they answered anything. A typical case is aconfirmed_onthat a spreadsheet program rewrote as26/10/2026, which #59 now refuses.Summary
notebook_ui.py:_open_designno longer writes whenload_designreports a problem. A new_design_unreadableflag records this state.run_experimentitself still refuses withdesign_not_confirmed.probleminstead of carrying on with the default designDecisions
Notes for review
runrefuses with "Correct the file, or delete it" and writes nothing, andcheckonly prints the problem. It is unchanged.load_designis unchanged: it still returns the default design together withproblem, and callers must checkproblem. Making it raise would change the public API, so I left it for the owner to decide.Tests
test_an_unreadable_design_is_left_untouched_until_answered(regression):DD/MM/YYYY.line 2, column confirmed_on, and leaves the design unconfirmed with the editor shown.confirmed=false.test_answering_again_replaces_an_unreadable_design: an explicit answer replaces the file and the note changes. It fails on old main because the note is missing.test_an_unreadable_design_is_asked_againnow also checks that the file is untouched before the answer..[dev,notebook,zarr]):ruff check .andruff format --check .are clean. pytest: 1462 passed, 1 skipped. The skip istests/test_discovery.py:665: the tests run as root, which ignores file modes.Generated by Claude Code