Repository navigation
Pin the normalization brick to its release v0.3.2 - #47
Merged
Merged
Conversation
morphobricks-normalization v0.3.2 (normalization#19) checks each plane_histograms.csv row's stored plane_id, image_file and bit_depth against the row's other columns when reading, so an inconsistent row is refused (CsvFormatError) instead of silently recomputed (issue #39, CSV item). pyproject, README and AGENTS now name v0.3.2. The package version is not changed (the release is separate). Regression test test_a_row_whose_plane_id_disagrees_with_its_columns_is_refused: DID NOT RAISE with v0.3.1, passes with v0.3.2; a rerun finding such a table recomputes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VbytvBRB9CmKQ5AAkhEFcv
Contributor
Author
|
Branch cut from the current main, no conflicts. The pin moves to normalization v0.3.2. The new plane_id regression test fails with v0.3.1 and passes in CI, so CI installed v0.3.2. 1131 passed, 1 skipped (test_discovery.py:472, root), ruff clean, CI 7/7 green on aafe8da. Merging. Generated by Claude Code |
This was referenced Oct 30, 2026
Closed
guijacquemet
pushed a commit
that referenced
this pull request
Nov 3, 2026
Normalization main 534c63d (#65, issue #47) refuses a PlaneHistogram with valid pixels and no pixel_min or pixel_max. The test now passes them from the version-2 columns; it passes with v0.3.3 (still the pin) and 534c63d. It is the only PlaneHistogram construction in src/ and tests/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.toml:morphobricks-normalization @ git+...@v0.3.1becomes@v0.3.2(tag on f784c95, reports 0.3.2), and the comment says what v0.3.2 adds.normalization v0.3.2 (normalization#19) checks each
plane_histograms.csvrow's storedplane_id,image_fileandbit_depthagainst the row's other columns when it reads the table. An inconsistent row now raisesCsvFormatError; before, it was silently recomputed. This is the CSV item of #39.Tests
test_a_row_whose_plane_id_disagrees_with_its_columns_is_refused. Changing one row's storedplane_idmakesread_plane_histogramsraiseCsvFormatError. A rerun that reads such a table recomputes it ("the earlier histogram table could not be read"). With v0.3.1 installed the test fails (DID NOT RAISE); with v0.3.2 it passes.pytestwith normalization 0.3.2 installed: 1131 passed, 1 skipped (test_discovery.py:472, root ignores file modes).ruff check .andruff format --check .are clean.Part of #39.
Generated by Claude Code