Repository navigation
Read and write channel_names_trimmed as a strict manifest flag - #45
Merged
Merged
Conversation
channel_names_trimmed (from #42) was read with bool(), so "false" or 1 in a manifest's file entry was turned into a boolean instead of refused, and the writer wrote any value it was given. It now goes through the same strict _flag as the other manifest flags (#44): a value that is not a JSON boolean makes the manifest malformed, and write_manifest refuses to write one. Regression tests: test_flags_must_be_json_booleans and test_the_writer_refuses_flags_that_are_not_booleans, extended with channel_names_trimmed (8 cases, all fail on main). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VbytvBRB9CmKQ5AAkhEFcv
Contributor
Author
|
This branch was cut from the current main and had no conflicts. Generated by Claude Code |
This was referenced Oct 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manifest.py:channel_names_trimmed(added in Make differing channel names at one channel number an error #42) is now read and written through Data-flow audit minor findings: unknown scale, manifest flags, per-file roles, uint64 labels #44's strict_flag, like the other manifest flags. Before this, the reader usedbool(...), so"false"or1was turned into a boolean instead of refused, and the writer wrote whatever it was given.docs/contract.md§9: the Flags row now listschannel_names_trimmed.Part of #39 (follow-up to the strict manifest flags in #44 and the trimming in #37/#42).
Tests
test_flags_must_be_json_booleansandtest_the_writer_refuses_flags_that_are_not_booleansnow includechannel_names_trimmed: 8 new cases, all 8 fail on main.pytest: 1129 passed, 1 skipped (test_discovery.py:472, root ignores file modes).ruff check .andruff format --check .are clean.Generated by Claude Code