Repository navigation
Refuse RGB units only for requests that name their channels (Spec §8): mask-only features on RGB slides - #298
Merged
Merged
Conversation
…v1 section 8) A_RGB_NOT_SUPPORTED applies, per the Spec, to "a request on a described run [that] includes the channels of an RGB unit". The resolver refused any request whose scope touched an rgb unit, mask-only requests included, so a brick's mask-only features (MorphoObjects shapes, MorphoRelate relations and skeletons) could not run on an RGB slide without declaring rgb_support. It now counts only the rgb images whose channels the request names. Owner decision of 14 November 2026: fix the code to the Spec; no new capability value. Test: on Spec v28, a mask-only request is accepted for any consumer; naming one of R, G, B is still A_RGB_NOT_SUPPORTED. tools/check.py: 5495 passed, 4 skipped (case-sensitive file system x3, running as root), 0 failed. Ruff and code rules are clean after shortening two lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VbytvF3Gsa85ix8Ne2yMDW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
experiment-v1 §8 defines
A_RGB_NOT_SUPPORTEDfor "a request on a described run [that] includes the channels of an RGB unit". The resolver refused any request whose scope touched anrgbunit, mask-only requests included. As a result, a brick's mask-only features could not run on an RGB slide (H&E, for example) unless the brick declaredrgb_support:Change (
run_inputs_resolve.py, one line, plus thergb_refusaldocstring): only thergbimages whose channels the request names count toward the refusal. Channel requests on RGB units are unchanged and still needrgb_support.Owner decision (14 November 2026): fix the code to the Spec. No new capability value.
Test: on Spec
v28, a mask-only request is accepted for any consumer, and naming one ofR,G,Bis stillA_RGB_NOT_SUPPORTED.Check:
tools/check.pygave 5495 passed, 4 skipped (case-sensitive file system ×3, running as root), 0 failed. Ruff and code rules are clean.Related: MorphoFeature #221 (
23bfe80) applies the same rule to its catalogue capability. It takes effect end to end with the preprocessing release that carries this PR and #295 (v0.5.4).Generated by Claude Code