Repository navigation
Notebook: axes proposed at the quick scan and validated on all images; pixel sizes that differ in one line (redesign 3, part 2) - #285
Merged
Conversation
…very image; differing pixel sizes in one line Owner's test of v0.5.1, items (s) and (x). The quick scan shows 'Axes of this image' (one list per dimension, from the header); a changed role redraws the pictures and becomes the proposal the Axes step starts from after the folder check validated it against every image. Three or more different pixel sizes are one line with their range and spread, a folded table and the two explicit choices. Run messages are short cards. Nothing is confirmed or chosen without a click; no published file changes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Contributor
Author
Independent review: #285 (axes proposed at the quick scan, one-line pixel-size disagreement)Verdict: approve. Merged the viewer branch (with main #289) forward as
Gate on Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesign iteration 3, part 2 of 4, stacked on #284. Items (s) and (x) of "OWNER v0.5.1 NOTEBOOK TEST" (RESTART.md).
Summary
notebook_scan_axes:prefill_mapping; a dimension the header does not name has no role, nothing is guessed);review_axes(unchanged) checks them against every image, and one line on Images says whether they fit all N images;Nothing is confirmed at the scan; roles that contradict a header are still refused (
axes_contradict_header); a new scan forgets the roles of the one before.pixel_size_summary.spread_line/combination_rows: with three or more different sizes in one unit, one line (Pixel sizes differ slightly: 0.10047–0.10054 µm (spread 0.07 %) across 28 images, 26 combinations), the sizes in a folded table (size, images, folders, source), and the two explicit choices: one size for all images (shown before it replaces anything, recorded as stated) or sizes per imaging unit. The per-unit tables no longer open by themselves. Until a choice is made each image keeps its own header's size, as before, and the page says so.Notes for review
Tests
tests/test_notebook_scan_axes.py(new) and the updated notebook tests; the full gate count is in the last PR of the stack.Generated by Claude Code