Repository navigation
Let other bricks embed the folder step without the experiment design - #27
Merged
Merged
Conversation
MorphoRelate's "your data" notebook embeds PreprocessingNotebook.folder_step. From v0.1.0, confirming the labels opens the "Experiment design" card, writes experiment_design.csv into a new <images>_MorphoBricks_Preprocessing folder beside the image folder, and says that step 3 runs once every group is confirmed. MorphoRelate does not use the file, and its step 3 is another step. folder_step takes show_design (default True). With False the card is left out of the page; confirming the labels asks nothing, design stays None and nothing is written (no file, no output folder). The labels question drops "Step 3 can only run once the labels are confirmed", and the "What next?" boxes of steps 1 and 2 no longer send the user to the design. Step 3, if shown, does not wait for a design and runs without one, as run_experiment(design=None). Building the page again with the other value opens or closes the design for labels already confirmed. The default page, its texts and its files are unchanged, pinned by a test. ConfirmToggle gains explain() to replace the text under its question. Nothing else in step 1 writes files: the folder check and header inspection only read. Tested headless (pages built, driven by clicks); not looked at in a browser or a real JupyterLab. Decision recorded as plan section 12 question 29; contract section 12 and AGENTS.md updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017TP44aBCGzyksTpPS2FFmQ
…uestion 31 P4 and P5 took plan §12 questions 29 and 30, so this change's decision is now question 31, with its references in plan §10 and question 26, contract §12 and AGENTS.md. Its test confirms the image type that step 3 now waits for (P4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
IvanHCenalmor
added a commit
that referenced
this pull request
Oct 27, 2026
PR #27 (folder step without the experiment design) takes question 31, and goes in first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
IvanHCenalmor
added a commit
that referenced
this pull request
Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@IvanHCenalmor, could you review this when you have time? We won't merge it ourselves. If you're happy with it, please merge it and tag a release, so MorphoRelate can move its pin to that tag (MorphoRelate#183).
Why
MorphoRelate's "your data" notebook embeds
folder_step(). Since v0.1.0, ticking "Yes, the labels are correct" there shows the Experiment design card and writesexperiment_design.csvinto a new<images>_MorphoBricks_Preprocessing/folder beside the images. MorphoRelate doesn't use that file, and the card's text points to this brick's Step 3, which MorphoRelate's notebook doesn't have. The owner chose an upstream option over a workaround in MorphoRelate (27 October 2026).Summary
notebook_ui:
PreprocessingNotebook.folder_steptakesshow_design, defaultTrue. WithFalse:designstaysNone;experiment_design.csv, no<images>_MorphoBricks_Preprocessing/folder;run_experiment(design=None)does.Building the page again with the other value opens or closes the design for labels already confirmed.
notebook_style:
ConfirmToggle.explain()replaces the text under a question.Docs: plan §12 question 29, with pointers in question 26 and §10; contract §12 (Notebook row); AGENTS.md.
Notes for review
mode="r"), and withshow_output=Falsethe output folder is only named.show_design=False. Without that, Step 3 would stay locked for good in a notebook that hides the design.Tests
show_design=True;show_design=False, confirming the labels and the axes writes nothing under the experiment's parent folder;show_design=False, the card and its words are absent.ruff check .andruff format --check .pass.Generated by Claude Code