Repository navigation
Notebook redesign 1: file lists without empty bullets, the references dropdown stays, disabled actions say why - #269
Merged
Conversation
…ys, disabled actions say why Owner test of v0.5.0 (10 November 2026), items (g), (i) and (j). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
…e/redesign-1-fixes Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
This was referenced Nov 10, 2026
Merged
Contributor
Author
|
Correction to the description: the stack is #269 (this), #270, #272 and #273 (not #271, #272). 🤖 Generated with Claude Code https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc Generated by Claude Code |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of four stacked pull requests that redesign the notebook app after the owner's test of v0.5.0 on real data (10 November 2026): #269 (this), #270, #271, #272. Design note:
docs/restart/designs/notebook-redesign-2026-11-10.mdon MorphoFeature branchclaude/restart-doc. This one holds the three small fixes, items (g), (i) and (j); nothing about when an answer is accepted or refused changes. Main (#267, #268) is merged in.Summary
notebook_style(g):path_listreturns plain lines in a box (scrolling above about ten lines) instead of a nested list, andstatusjoins a list of paths to the line before it. A list of files in an error card drew an empty bullet before it, and bullets inside "Show N more". Same paths (still bold), same fold.notebook_description(i): choosing what a condition "is compared against" rebuilt every dropdown of the card, twice, so the control vanished while the answer was saved. The rows are built once per set of conditions and updated in place (_build_references,_new_reference_rows,reference_notes). The answer, its refusal (a loop) and the saved draft are unchanged.notebook_render.blocked_line(j) and its uses: every disabled action has a visible line beside it saying what blocks it. Confirm axis roles names the axis error (different channel counts), the preview not drawn, or the preview not ticked; also Yes, the preview looks right, Compute histograms, Yes, save the experiment description, Make named-axis copies and its roles question, and the stains confirmation.Decisions
different_channel_counts); the refusal is now named beside the button instead of only in a tooltip.save_blocker):save_notekeeps meaning "the run will stop" only.Notes for review
Tests
python tools/check.pyonb5461fd(main merged): Ruff and the code rules pass; 5182 passed, 4 skipped (the four environment skips:test_cli_log.py:166,test_folder_rules.py:199and:230for a file system that tells names apart by case;test_discovery.py:665for running with permissions that ignore file modes). New:tests/test_notebook_owner_fixes.py(19 tests: the list for 1 to 90 paths, the dropdown object surviving a choice and a refusal, each blocker line).🤖 Generated with Claude Code
https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc