Repository navigation
PP-C1: drop the v0.4.0 parity tests, keep the histogram goldens (v0.5.1, 1/3) - #259
Merged
Merged
Conversation
Owner ruling 6 of 10 November 2026 (Stage 2 plan §0.2, SWEEP-PP item PP-10): no backward compatibility before the first pipeline release. - Delete test_parity_v0_4_0.py and parity_datasets.py (parity with the v0.4.0 tag) and test_removed_in_v040.py (guards on names removed in v0.4.0). - Keep the independently computed histogram values as science goldens, renamed without the "old version" framing: test_schema_v2_equivalence.py -> test_histogram_goldens.py, v2_fixture.py -> histogram_goldens.py, tests/data/v2_* -> golden_*, make_v2_fixture.py -> make_histogram_goldens.py. Its pure old-version check (a version-2 table under a version-2 manifest) is deleted; "a table of an older format is recomputed" is kept. Tests only; no source change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PP-C1 of 3 (stacked): PP-C, the first change of v0.5.1. Base
main(3f10545). Next: PP-C2 #260 (core, run paths, notebook, tests), then PP-C3 #261 (docs). Do not merge before the independent review.Owner ruling 6 of 10 November 2026 (Stage 2 plan §0.2; inventory PP-10, §12 rulings 5 and 6): the v0.4.0 parity tests go; independently computed numeric goldens stay, renamed without the "old version" framing.
Summary
tests/test_parity_v0_4_0.py(4 tests, parity with thev0.4.0tag),tests/parity_datasets.py,tests/test_removed_in_v040.py(6 tests).test_schema_v2_equivalence.py→test_histogram_goldens.py,v2_fixture.py→histogram_goldens.py,tests/data/v2_{pixels.npz,float32.csv,uint16.csv}→golden_*,make_v2_fixture.py→make_histogram_goldens.py. Tests:test_histograms_equal_the_reference_values,test_step_4_statistics_equal_the_reference_values,test_a_table_of_an_older_format_is_recomputed. The pure old-version check (test_a_version_2_table_is_recomputed_on_the_next_run, a version-2 manifest) is deleted. The reference data bytes are unchanged.Tests only; no source change.
released_code.py, the rc4 manifest and CI'sfetch-depth: 0go in PP-C2, with the manifest-version tests that still use them.Tests
python tools/check.pypieces:ruff check .,ruff format --check .clean; code rules against the baseline: no violation.pytest(Python 3.13, Linux): 5065 passed, 4 skipped (environment skips: case-insensitive file system ×3, permissions ignored as root ×1); Spec modules unchanged (0 skips).Notes for review
docs/conformance.md(the v0.5.0 G1 record) still namestest_parity_v0_4_0; it is a dated record of the v0.5.0 gate and is left as it is.https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Generated by Claude Code