Repository navigation
Notebook: Stains is not applicable when every folder is colour (RGB) - #249
Merged
Merged
Conversation
…ur (RGB) Experiment-v1 section 4.4b fixes R, G and B as the channels of an rgb unit, so an experiment whose every folder the user declared rgb needs no channel label. Stains then reads "not applicable: every folder is colour (RGB)" (chip done, noted), Tag channels opens without labels, and Check and save completes. Mixed or unanswered image types, and the header's unconfirmed colour pre-tick, keep the labels required. Fixes #240 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
…r; tighten tests - The "first name what you stained" intro contradicts the not-applicable card, so it is hidden while every folder is declared colour. - all_colour requires the saved rgb answer to still fit the image (3 channels). - The mixed-experiment test was vacuous (no axis roles confirmed, so no layouts): replaced by a folder left on the header pre-tick. Added the stale-labels case (valid; W_UNUSED_CHANNEL per the vendored refval) and an all_colour unit test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
guijacquemet
pushed a commit
that referenced
this pull request
Nov 9, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240
What
When the user has declared every folder
rgb(saved image-type answers only; never the header's unconfirmed pre-tick), the Stains step (8) is "not applicable: every folder is colour (RGB)". Its chip shows done with a "not applicable" note, Tag channels opens without labels (and is done), and Check and save completes without a channel label. Mixed or unanswered image types keep today's behaviour.Spec
experiment-v1 section 4.4b (RGB imaging units): an
rgbunit lists exactly["R", "G", "B"], which are fixed tokens with no aliases; section 4.3 (channels) only needs declared IDs. So no label is required. Saving already wrote exactly this (channels.R/G/Bwith noheader_names, unitsimage_type = "rgb",channels = ["R","G","B"]); a test pins it.Change
channel_answers.all_colour: true only when every layout is usable with a savedrgbanswer.notebook_channels:_stains_not_applicable; the grid opens when labels are confirmed or not applicable.LabelsCard.set_not_applicable: hides the questions and says why. Already-declared labels stay saved.notebook_step_states/notebook_steps: Stains and Tags states and the wait message.Tests
tests/test_notebook_stains_na.py: an all-RGB fixture completes Stains and Check and save with no label and saves (fails on main); saved file content; header pre-tick alone, mixed, and one-folder-changed cases still require the label.python tools/check.py: 4993 passed, 4 skipped (case-insensitive FS x3, file-mode x1).Generated by Claude Code