Repository navigation
Notebook: your masks (Stage 1, PR 16a) - #237
Merged
Merged
Conversation
Screen 4 of the natural design: separate objects or regions, no default (experiment-v1 4.5), the mask ID is the folder name when it is a valid mask ID, optional made-from channels, beside the evidence (images with the mask, dtype, values in one image, the mask drawn on the image only as declared). Step 3's Describe the masks shows these IDs and no longer asks to name the masks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
…R 16a) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
guijacquemet
marked this pull request as ready for review
November 9, 2026 05:58
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 1 notebook PR 16a: screen 4 Your masks and the Step 3 reuse of its IDs (design
notebook-natural-design-2026-11-08.md§2 "Screen 4", owner answer 4). PR 16b (screen 5 Check and save, reopen, thumbnails on screen 2, retiring the global Image type card and labels toggle) is stacked on this one.What the screen does
instances) or regions: inside or outside (binary). Nothing preselected (experiment-v1 §4.5).in:draft_ids.id_problems("masks", …), the reader's own rules). Otherwise the box is empty and says why (nuclei-mask:E_ID_SYNTAX;cell:E_ID_RESERVED), and the user types one. Nothing is repaired.source_channels.masks.read_mask), and two pictures: the image channel (PR 13channel_strip), and the mask reduced with the same step (preview.labels_thumbnail, never interpolated). Before an answer the mask is drawn alone in grey; after it, as declared (mask_overlay_png: outlines or tint). The mask is drawn on the channel tagged with its first made from label, else channel 1, and the caption says which.morphobricks.draft.json(DraftAnswers.masks); the card is a self-containedMasksCardreading and saving through theAnswerStore, like Notebook: your channels (labels first, then tag per unit) (Stage 1, PR 15) #233's cards (owner note).not described yetfor an unanswered type) and no longer says "name each mask".Library
mask_answers.py(pure):with_mask,without_mask,proposed_mask_id,mask_ids,masks_unanswered,masks_without_files,dropped_channels,drawn_on.mask_evidence.py(io):mask_evidence,representative.preview.labels_thumbnail.draft_idskindmasks.mask_text.mask_type_rows(report, ids).Tests
tests/test_notebook_masks_screen.py(9 headless widget tests),tests/test_mask_answers.py(20 library tests), one new test intests/test_notebook_mask_step.py(IDs reused, no "name each mask"). All fail onorigin/main(the modules and the column do not exist there).Gate (
python tools/check.py,.[dev,notebook,zarr], Python 3.13): ruff check and format clean, code rules clean (no baseline grown), 4802 passed, 4 skipped (the existing case-sensitive file system and file-mode skips), and 1 failure: the embedding API pin of the new publicmasks_step. Fixed in459dd02(pinned);tests/test_embedding_api.pythen passed 36/36. CI on459dd02: all 7 jobs green.Screenshots (rendered in Chromium from real widget state, synthetic structured images) are in the PR 16b report:
pr16-02-screen4-masks-unanswered.pngandpr16-03-screen4-masks-answered.png.https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Generated by Claude Code