Repository navigation
List images without header channel names in a described run - #226
Merged
Merged
Conversation
An image whose header names no channel, or not every one, still passes the per-unit header checks (Spec 4.3, fixture v12), with no warning. It is now listed: the unit record of the manifest's experiment_description entry gets images_without_header_channel_names (read back strictly), RunInputs exposes it read-only, and the report text and JSON list the images. Undescribed runs are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Scma6W3LC11s3qjXHZuGDm
…eader-images # Conflicts: # CHANGELOG.md
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225
What
In a run with a published description, an image whose header names no channel (or not every one) still passes the per-unit header checks (#218; Spec §4.3, fixture v12), with no warning. It is now listed:
experiment_description.unitsgetsimages_without_header_channel_names, a list sorted by path of{image, header_names: "none"|"partial", channel_positions: [zero-based C positions without a name]}. The key is omitted for a unit whose images are all named (documented indocs/contract.md); RGB units list nothing (§4.4b).read_manifestvalidates the field strictly (ManifestFormatErroron a wrong shape, order, type or value).RunInputs.images_without_header_channel_names()returns it read-only ({path: positions}; empty when all named; None without a description).images_without_header_channel_names(empty list when none), only for described runs.New code is in the new module
description_unnamed.py(layerpure), somanifest.pystays at 598 lines; no baseline grew.Why
Owner decision 2026-11-08: keep these images passing but make visible which ones stand on the user's confirmed layout alone; no warning.
Regression evidence
tests/test_unnamed_header_images.py(13 tests): 13 failed onmain(source stashed), 13 pass here. They cover a described run with one unnamed and one partially named image (exactly those two recorded, manifest round-trip viaread_manifest,RunInputs, report text and JSON, no issues), a fully named run (key omitted, report list empty), an undescribed run (no new key), 8 malformed manifest lists refused, and the physical report.Checks
python tools/check.py: ruff check and format clean, 4582 passed, 4 skipped (case-insensitive file system and file-mode permission skips, unrelated), code rules clean (v0.4.0 parity suite included and passing).Expect CHANGELOG conflicts with #217 and #224; keep both sides.
Generated by Claude Code