Repository navigation
Re-pin the vendored Spec to b197ac1; reserved names apply to used_ids.channels - #208
Merged
Merged
Conversation
…ids.channels Owner decision UR1 (MorphoBricks-Spec PR 12): a reserved name in used_ids.channels is E_ID_RESERVED. New fixtures i135 (invalid) and v37 (valid); refval updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Scma6W3LC11s3qjXHZuGDm
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Scma6W3LC11s3qjXHZuGDm # Conflicts: # CHANGELOG.md
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PIN.tomlholds the four new values (commit,fixturestree,experiment-v1.mdblob,refval.pyblob);fixtures/is byte-identical to the Spec's (checked withdiff -r).i135_used_id_channel_reserved(invalid) andv37_used_ids_reserved_near_misses(valid);experiment-v1.md,fixtures/README.mdandrefval.pyupdated.description_identity._used_idsnow applies the reserved list of Spec 3.2 toused_ids.channelsentries (E_ID_RESERVED, same check as a declared channel ID). The other threeused_idskinds are unchanged, as in the Spec and refval.tests/test_spec_reader.py: fixture counts 36/134/13 become 37/135/13. No newtest_spec_*module, sospec_gate.EXPECTED_MODULESis unchanged.Not touched:
run/description_file.pyand the records code. The new Spec text aboutremovedandimage_count_changedrecords is outside this change (records file work is PR #207).Regression
With the new vendored files and the old reader,
tests/test_spec_reader.py::test_an_invalid_file_gives_exactly_its_codes_from_its_phase[i135_used_id_channel_reserved]FAILS (the reader accepts the file). The refval cross-check also fails on the old reader fori135,i61,i107,i108and thev36one-step mutations. All pass with the fix.Checks
-k spec): 1526 passed (every fixture exact, refval cross-check 0 differences).python tools/check.py: 4169 passed, 4 skipped, 2 warnings. The 4 skips are the existing case-insensitive file system and file-mode skips (test_cli_log,test_discovery,test_folder_rulesx2), none of them in a Spec test.Generated by Claude Code