Repository navigation
Re-pin the vendored Spec to 7dbae0c (byte rules, goldens, t13, records encoding) - #195
Merged
Merged
Conversation
Fixtures (goldens in expected/, t13), experiment-v1.md and refval at MorphoBricks-Spec 7dbae0c. Reader and reference validator agree on all fixtures and mutations; the oracle no longer differs on image_count. New byte-level tests for section digests (9.3) and morphobricks.records.jsonl (4.6). read_records split at U+2028/U+0085 as well as LF; now LF only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Scma6W3LC11s3qjXHZuGDm
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Scma6W3LC11s3qjXHZuGDm
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Scma6W3LC11s3qjXHZuGDm # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-pins
tests/spec_fixtures/to MorphoBricks-Spec7dbae0c(its PR 9 merged): fixtures,docs/experiment-v1.mdandtools/audit/refval.py, withPIN.tomlupdated (commit,fixturestree, the two blob IDs). Files were taken withgit archive/git showfrom a worktree at that commit.New in the pin:
experiment_design.csv, and golden filesfixtures/expected/forv13,v33,v34;t13, a changedimage_countalone does not reopen a confirmation (a newconfirmed_onbeside it isR_CONFIRMED_ON_CHANGED);morphobricks.records.jsonl.Agreement with the Spec
image_count, sotest_spec_transitions.pydrops its "set every image_count to 1" workaround and compares the pairs as they are (13 transitions now).tests/test_spec_encoding.pycheckssection_digestsequals the oracle's on every valid and transition fixture, and that a section with no tables is the SHA-256 of the empty bytes. The writer already matched; no change needed.read_recordssplit the file withstr.splitlines(), which also cuts at U+2028 and U+0085. A record holding such a character (written unescaped, as the Spec requires) was then refused as "not JSON". Lines now end at LF only.spec_pin.catalogueno longer reads the golden-file rows of the fixtures README as fixtures.experiment_design.csvfrom a description yet. That is Stage 1 PR 10, the next PR, which will compare against them byte for byte.Tests
Regression for the defect:
test_non_ascii_text_is_written_unescaped_and_read_back_wholefails on the old code (RecordsFileError: ... holds a line that is not JSON), passes now. Before the helper and count updates, the re-pinned fixtures also failedtest_the_catalogue_lists_every_file_and_nothing_else[valid]andtest_the_fixture_counts_are_the_catalogue_s(13 transitions); both are fixed here.python tools/check.py: 3911 passed, 4 skipped, code rules clean. The 4 skips are environment ones (case-insensitive file system and file-mode tests, unrelated to this change). No Spec test is skipped (the gate holds them to it).Generated by Claude Code