Skip to content

[Sad Catapella B5][Scientific integrity] Source files may change between fingerprint capture and histogram publication #90

Closed

Description

@guijacquemet

Baseline / classification

Adversarial audit Batch 5 at d7a538e56d41ac1093ba79adcad397c21b3dfd32. Confirmed TOCTOU validation gap; no concurrent-acquisition reproducer run.

Evidence

Deterministic test

Instrument iter_xyc_planes to mutate one source TIFF's valid pixel data, keeping geometry/dtype, after the initial fingerprint or between histogram passes. Verify that a successful run never records a fingerprint of one image generation while its table describes another generation; assert explicit refusal and no publication. Include Zarr chunks, source file deletion, and remote-writer cases. For a simple TIFF, an actual mtime increase may be caught on next run; that does not protect the published run from an inconsistent snapshot.

Fix

Capture a beginning-and-end signature for every input whose pixels were read; before committing compare it to the pre-read signature and block/retry if changed. For stronger correctness across a multi-pass read, require immutable input snapshots / stable versions or per-chunk content hashing where practical (#86). Document that directory timestamps cannot detect all mutations. Avoid silent replacement of source fingerprints after work. Benchmark signature validation overhead. No Numba value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions