Repository navigation
Refuse incompatible summaries: dimensions, percentile definitions, dtypes - #77
Merged
Merged
Conversation
ImageSummary now checks that its per-channel tuples have one non-zero length, and intensity_checks refuses summaries with different numbers of channels, naming the images, instead of skipping the repeat check or raising IndexError. Fixes #56 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VbytvF3Gsa85ix8Ne2yMDW
intensity_checks compared p_high values of summaries computed at different percentiles. It now raises IncompatibleSummariesError naming the images and both percentile pairs. Fixes #55 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VbytvF3Gsa85ix8Ne2yMDW
The saturated fraction took the pixel type from the first histogram and applied its maximum to every plane. image_summaries now raises IncompatibleSummariesError naming the planes and their pixel types. Fixes #54 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VbytvF3Gsa85ix8Ne2yMDW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VbytvF3Gsa85ix8Ne2yMDW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56, fixes #55, fixes #54
One commit per issue, each with a regression test that fails on main; a last small commit documents
_summaryand lowers the code-rules baseline.ImageSummaryrefuses per-channel tuples of different or zero length;intensity_checksrefuses summaries with different channel counts.intensity_checksrefuses summaries with different percentile definitions, naming images and both pairs.image_summariesrefuses an image whose Z/T planes have different pixel types, naming the planes.All raise the new
IncompatibleSummariesError(aValueError).Bitwise result:
tools/dump_outputs.pySHA-256 is identical on main (3b5378a) and this branch:dfd5e740e04e16057bc6a017e844ae62cb94025690531b443a9489f52900537e.Gate:
python tools/check.pypasses, 675 passed, 2 skipped (csbdeep not installed).Generated by Claude Code