Repository navigation
Require Python 3.11; position_id follows the MorphoBricks FOV key - #4
Merged
Merged
Conversation
- requires-python >=3.11 and Ruff target py311 (MorphoBricks decision D01: every brick installs in one Python 3.11 environment); CI matrix 3.11 and 3.13; AGENTS style line. - contract 8.2 and PlaneRecord: position_id is the XY position within its technical repeat (decision D02), from reliable metadata or the file stem when one file is one position, as morphobricks-preprocessing now writes it. The CSV schema is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U6vJfhGWQ7pTpsJhw48Zf7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requires-pythonchanges from>=3.10to>=3.11, and the Ruff target frompy310topy311. The CI test matrix changes from 3.10/3.13 to 3.11/3.13. The AGENTS style line is updated.PlaneRecord:position_idis now the XY position within its technical repeat. It comes from reliable metadata, or from the file name without extension when one file holds exactly one position. This matches what morphobricks-preprocessing writes after Fill position_id per image (D02) and require Python 3.11 (D01) morphobricks-preprocessing#19. Before, the contract said it was "never inferred from file names". The CSV schema and code behaviour are unchanged; only the description changes.Decisions
These follow the MorphoBricks owner decisions of 2026-10-26, recorded in the MorphoFeature decision ledger (CellMigrationLab/MorphoFeature#6):
condition+biological_repeat+technical_repeat+position_id.Notes for review
py311required no code changes.requires-python.Tests (local)
ruff check .all passed;ruff format --check .19 files already formatted;pytest140 passed.pytest140 passed.pip install -e .is refused, which is intended.Do not merge without the owner's go-ahead.
Generated by Claude Code