Repository navigation
Template 0.1.24: download links for "v" tags, installers only for the supported systems, the app's own Jupyter kernel - #45
Merged
Conversation
… supported systems, the app's own Jupyter kernel - #41: the release workflow exports the tag as typed (RELEASE_TAG); bump_version.py points the download links to it and keeps the bare version in the installer names. It reads the tag from the environment, so an unchanged bump_version.py keeps working. - #42: new .tools/python/release_platforms.py reads distribution.platforms of labconstrictor-app.yaml; a new platforms job writes the build matrix, and the download page gets a note instead of the button of a system that is not built. Without the key, every system is built as before. - #43: launch_jupyter.py sets JUPYTER_PREFER_ENV_PATH=1 before JupyterLab starts, so the app's own kernel wins over a user-level "python3" kernelspec. - Migration v0_1_23_to_v0_1_24.py (surgical, idempotent, SKIPPED for customised files), design note migration_0_1_24.md, docs and tests (tests/test_template_sync_0_1_24.py; tests/_v0_1_24.py keeps the frozen resources of older migrations comparable with the live files). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41, fixes #42, fixes #43. Design note:
.tools/docs/migration_0_1_24.md.Problems (all three found with StarDist2D 1.0.0)
v1.0.0wrote download links to/releases/download/1.0.0/...; the release folder isv1.0.0, so every download button returned 404.python3kernelspec (ipykernel install --user) over the app's own, so the notebook ran in another Python:No module named '<app>'.Changes
release_constructor.yml: both "Determine release version" steps also export the tag as typed (RELEASE_TAG). A newplatformsjob runsrelease_platforms.py; the build job takes its matrix from it (fromJSON(needs.platforms.outputs.matrix))..tools/python/release_platforms.py(new):distribution.platformsoflabconstrictor-app.yamland writes the matrix;windows-arm64/linux-arm64have no build).bump_version.py:--tag, default$RELEASE_TAG, else the version), and the installer names keep the bare version;X.Y.ZnorvX.Y.Zis refused;The tag comes from the environment, so the workflow and this script do not depend on each other: an unchanged (customised)
bump_version.pykeeps working, with the old links.launch_jupyter.py:run_jupyter()setsJUPYTER_PREFER_ENV_PATH=1before importing JupyterLab. It is set, not defaulted, so a user's0cannot bring the bug back.Migration
v0_1_23_to_v0_1_24.py:release_platforms.pyand changes known exact blocks only;Docs:
migration_0_1_24.md, the release guide (avtag works), the app manifest guide (platformsdecides the builds), and both troubleshooting pages.Tests:
tests/test_template_sync_0_1_24.py(34 tests);tests/_v0_1_24.pyundoes the 0.1.24 blocks, so the frozen resources of the 0.1.13 / 0.1.18 / 0.1.20 migrations are still compared with the live files.Verified
main(bash and path-separator tests that pass on Linux), and none are new.bump_version.pywas run with avX.Y.Ztag:vtag;bump_version.pyis updated and keeps its pre-release check;Not verified
platformsjob and thefromJSONmatrix are checked by reading them and parsing the YAML in tests.🤖 Generated with Claude Code