Repository navigation
Fix: error codes and validation (F1 F5 F6 F11 F12 F15 F16 F20) - #41
Merged
Merged
Conversation
…-text paths, bad_return for wrong returns, refuse unusable images, refuse hint misuse (F1 F5 F6 F11 F12 F15 F16 F20) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
…ze-proof shared-memory test Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
…tically on every Python Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the first theme of the round-trip findings. Every case that the matrix skipped for these findings now runs as a normal test; the findings are removed from
tests/roundtrip_known_failures.py.Before -> after
invalid_parameter('N' must be an integer, got <what>).3.0is still accepted for an integer; the text "3" is refused for a number (hosts must send a JSON number).invalid_parameter.unreadable_imagewith a message saying what the host must do.bad_returnnaming the output and what was expected; a message output that is not text, a file output that is not a path, a values output that is not a mapping, and several outputs given a bare array are refused too (before:str()of whatever came back, or a numpy truth-value error).bad_return(was delivered as null).bad_return; complex, object, text and bytes arrays areunsupported_dtype;uint64beyond float32 is refused withunsupported_dtypeon every machine (the float32 exactness check no longer uses an out-of-range cast, which stored 264-1 as 264 on ARM).Min/Maxon a non-number, a non-finite bound,MinaboveMax,PixelSizeOfon a non-float,Axeson a non-image,Name/Replace/ApplyToon an input, and two outputs with the sameNameare now aDeclarationErrorat registration (they were silently accepted or renamed). An app that carried one of these mistakes will stop registering: I described the tools of VLab4Mic, Playground, GuessTheCondition and NucleiSky (bridge-test) with this branch and all register; CellTracksColab was not checked.Test edits (exceptions to "no existing test edited"):
tests/test_sabotage.py: four break patches changed text because the lines they patch moved (same breaks).test_roundtrip_known_failures.py::test_the_skip_is_exactly_the_listused an F1 id as a sentinel; replaced by a check independent of any one id. No existing test encoded the buggy behaviour.Docs:
PROTOCOL.md(value rules, returns, image outputs, uint64),MANIFEST.md(refused hint misuse),REGRESSION_LEDGER.md.Host follow-ups (not in this PR): mirror the messages above where a host validates before sending, send numbers as numbers and paths as text, send the full shared-memory descriptor and keep the block alive until the task ends. Tracked in the host parity work.
Verified by the author: black, ruff, mypy, vulture; the full suite has only the two environmental failures of this sandbox. Not verified: Windows, macOS, ARM, the coverage gate (CI runs it).
🤖 Generated with Claude Code
https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Generated by Claude Code