Repository navigation
Clean-up 2/3: functions that do one thing (nothing over 60 lines) - #35
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
…teps Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
…helpers Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
This was referenced Oct 12, 2026
guijacquemet
added a commit
that referenced
this pull request
Oct 14, 2026
…y) (#134) All three hosts honour the app_hosts_v1 rule (Napari #61, QuPath #35, Fiji #47 merged); template #33 is not merged. Sweeps README, HOST_FEATURES, REPOSITORIES, PROTOCOL, HUMAN_TEST_PROTOCOL, TESTING, the release sandbox README and two case files; OPERATIONS: Napari row (no main.zip since #60, placeholder <NAPARI_TAG>) and planned release numbers; TESTING: Known CI flake note. Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theme 2 of the clean-up pass (plan section 5). Pure refactor: no public name, output text, ordering, exception type, schema or protocol message changes, and no existing test was edited. 7 commits, one per module or related group.
Longest functions before -> after:
introspection._param102 -> short driver +_add_type_fields,_add_number_fields,_add_display_fields,_add_widget_fields,_add_dependency_fields(same order, so key order and the first error raised are unchanged);testing._compare87 -> a dispatcher over six_compare_*;__main__.build_parser85 -> one_add_<command>_commandper subcommand (top-level and every subcommand help diffed byte for byte);client.WorkerProcess.__init__81 -> 51 (_worker_env,_spawn);testing.run_case74 -> 42;cli.cmd_run64 -> 43;cli.diagnose63 ->_diagnose_app;registry.register63 -> 40;worker._run_task62 -> two outcome helpers. Nothing is over 60 lines now; nine are between 40 and 51 and were judged readable as they are.Verification: the same test counts as before the change (225 passed, 2 skipped, 11 subtests; the one flaky-under-load test did not flake). Because the two riskiest splits (
_param,_compare) have error paths the tests only partly cover, I also compared the generated schemas of every real app declaration on main vs this branch: the example apps, NucleiSky, GuessTheCondition, the Playground and VLab4Mic all produce byte-identical JSON (key order included); and I ran real tool cases through the splittesting.py(Playground feature tour, NucleiSky devices): all pass. Not run: the root-only deselected test.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Generated by Claude Code