Repository navigation
Record two decisions of 13 Oct: changed-size sentence, crash after Cancel (spec, data, fixtures) - #121
Merged
Conversation
…ncel Spec 4.4, 3.2, 3.7 and 8, conformance.json (messages.target_changed_size, retention.done_status, RUN-07, HRET-05, HRET-06), schema checks, tests, sabotage rows and a ledger row. - A source that is still open but changed size while the tool ran is not drawn, its files are kept, and the host says "run <run_id> on 'A': 'A' changed size while the tool ran; results are in <path>". The "no longer open" sentence of 4.4 stays as it is. - A task that crashes after the person pressed Cancel is recorded as cancelled (HOST_PARITY J08); a crash without Cancel is failed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs and data only (plus the schema checks that tie the data together). Found by napari phase 2 theme 1 (LabConstrictor-napari #51). No production code changes.
Decided (user, 13 Oct)
a) A source that is still open but changed size (shape) while the tool ran. The result is not drawn, its files are kept in the owned results folder, the host code stays
target_unavailable, and the status says:run <run_id> on '<source>': '<source>' changed size while the tool ran; results are in <path>The "no longer open" sentence of 4.4 stays exactly as it is and is only for a source that is gone.
conformance.json:messages.target_changed_size(same placeholders astarget_unavailable); RUN-04 now namesmessage: target_unavailable, RUN-07 namesmessage: target_changed_sizeandcode: target_unavailable; the schema checks that a named message or code existsb) A task that crashes after the person pressed Cancel is recorded
cancelled; a crash with no prior Cancel isfailed(HOST_PARITY J08).conformance.json:wrong_science.retention.done_status(by_task_status,crashed_after_cancel), HRET-05 and HRET-06 withtask_status,cancel_requested,done_statusconformance.prescribed_done_status(rule, task_status, cancel_requested)is the one reader of the ruleOnly a crash is read through Cancel: a task that ends
FAILED(the tool raised) isfailedeven if Cancel was pressed. Say so if you want that the other way.Tests
tests/test_conformance.py::DecidedOn13Oct(exact sentences, RUN-04/07 wiring, the map againstruns._DONE_STATUS,cli._DONE_STATUSand the client's task statuses, HRET-05/06 against the rule, the spec text) and eight new damage cases inSchematests/test_sabotage.py(schema checks and data), each caught by assertionContradiction with production code
runs.record(CLI) still maps a crash after Cancel tofailed. The CLI cannot produce that case today (run_oncenever callsTask.cancel, Ctrl-C writescancelleditself), so nothing observable is wrong; the follow-up code PR (run record without pruning) adds the shared helper and applies the rule.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Generated by Claude Code