Repository navigation
Fix main CI on Windows/macOS Python 3.10 (wheel test, conformance CLI test) - #118
Merged
Merged
Conversation
…>=70.1, CLI test needs SYSTEMROOT The wheel test died with SystemExit "invalid command 'bdist_wheel'" on the 3.10 runners (setuptools older than 70.1) because only Exception was caught. The test extra now asks for setuptools>=70.1, and the test skips only on that exact message; any other error fails. test_the_command_line_gives_the_path_and_validates started Python with an empty environment, which Windows 3.10 cannot do without SYSTEMROOT; it now passes it and shows stderr on failure. Ledger row and a TESTING.md note on the PR matrix hiding 3.10 on Windows/macOS. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main CI is red on Windows and macOS with Python 3.10 (runs 38291903402, 38294220866, 38295558295). Pull requests run those two only on 3.12, so the PRs were green.
Two failing tests, both only on the 3.10 runners:
test_conformance.Packaging.test_the_built_wheel_contains_the_file_and_the_loader_reads_it_from_there(macOS and Windows):build_meta.build_wheelexits withSystemExit ... invalid command 'bdist_wheel'because the runner's setuptools is older than 70.1. The test only caughtException, so the exit was an error.test_conformance.Loader.test_the_command_line_gives_the_path_and_validates(Windows 3.10 only): the subprocess was started with an environment of onlyPYTHONPATHandPATH="", and printed nothing. Windows needsSYSTEMROOT. The test now passes it and shows stderr in the failure message. (Inferred from the log, which shows only the empty output: the dispatched run on this branch confirms it.)Changes:
pyproject.toml: thetestextra asks forsetuptools>=70.1(bdist_wheel built in, so no separatewheel).[build-system] requiresstayssetuptools>=64: the test calls the installed backend in process, so the installed version is what matters.SystemExitcarriesinvalid command 'bdist_wheel'. Any other exit, and any other exception, now fails (the blanket skip onExceptionis gone). No other test builds a wheel or calls a build backend.docs/REGRESSION_LEDGER.md: one row.docs/TESTING.md: says pull requests do not run Windows/macOS on 3.10, which hid this, and how to run the full matrix on a branch (gh workflow run ci.yml --ref <branch>, aworkflow_dispatchrun).Checked locally: black, ruff, mypy, vulture clean;
test_conformanceandtest_roundtrip_ledgerpass; with setuptools 65.5.1 the wheel test skips with the reason, with setuptools >= 70.1 it passes.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Generated by Claude Code