Repository navigation
Notebook form: refuse an integer beyond 2^53-1 with the sentence of spec 6.2 (NUM-02, NUM-03) - #116
Merged
Merged
Conversation
…the spec (NUM-02, NUM-03) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Contributor
Author
|
Local full suite as the non-root user tester, private TMPDIR (cleaned up afterwards): all tests pass except 2 in test_tools_features (test_register_writes_them_into_the_entry_and_the_cached_schema, test_doctor_prints_them_and_does_not_call_an_upgrade_stale). Those fail only in this sandbox, unrelated to this PR: the app interpreter /usr/bin/python imports an old editable install of Tools from /tmp/wt_versions (no retention_prune feature). CI is green on every job. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notebook form refused an integer beyond 2^53-1 with
'L' is N, beyond the +-9007199254740991 the form can hold exactly: type a smaller number, .... Spec 6.2 (vectors NUM-02, NUM-03) asks for the worker templates, whichconformance.jsoncarries asmessages.number_above_maximumandnumber_below_minimum. Now the form says:'L' must be <= 9007199254740991'L' must be >= -9007199254740991where
Lis the field's label. Nothing else changes: codeinvalid_parameter, the value is never changed or clamped, no run starts, the tooltip (Whole numbers up to +-N.) is untouched. OnlyToolForm.valuesinlabconstrictor_tools/notebook.pychanges (the old singleabs(value) >check becomes two checks, one per template).Tests
tests/test_notebook_unset_and_range.py:test_NUM_02_and_NUM_03_use_the_sentences_of_the_spec_and_start_no_runtakes the vectors and templates fromconformance.json(typed values and the sentence in the vector'sexpect), goes throughToolForm.run()and checks the status text exactly, that the tool never ran, that the control keeps the typed value, andvalues()raises the same message;test_NUM_01_the_largest_exact_integer_is_sent_unchangedcovers the accepted edge. The older test (MAX+1refused,MAXaccepted) still passes.tests/test_sabotage.py: four rowsnotebook form: ...(old sentence, lost minus sign,>=instead of>, negative limit moved).docs/REGRESSION_LEDGER.md: one row (2026-10-12), inserted after the F4 row (not at the end of the table, to stay clear of other PRs).docs/CONFORMANCE.md: Gaps item 6 (this divergence) removed; the other numbers are unchanged on purpose.black, ruff, mypy, vulture clean; relevant tests and the sabotage rows pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Y2SN8SuEakTdiWy3F2WUqN
Generated by Claude Code